Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad Block detection is broken in chrome #141

Open
adamgamble opened this issue Dec 14, 2016 · 1 comment
Open

Ad Block detection is broken in chrome #141

adamgamble opened this issue Dec 14, 2016 · 1 comment

Comments

@adamgamble
Copy link

adamgamble commented Dec 14, 2016

Here is an example: http://s3.amazonaws.com/dfp-test-block/index.html?google_console=1&networkID=15572793&adunitID=Leader&dimensions=728x90

Within the last week or so something has changed (I assume in DFP somewhere) and its triggering the adblock code in jquery dfp even if no adblocker is installed. The "afterAdBlocked" callback fires even if the ad loads. It appears to possibly be a race condition? This only seems to be happening in chrome. I used browserstack to try several different older versions of chrome and it happens in everyone one I tried, so I don't think its a chrome version thing.

@adamgamble adamgamble changed the title Ad Block detection is broken. Ad Block detection is broken in chrome Dec 14, 2016
@BowlingX
Copy link
Contributor

I found the issue, will provide a pull request

BowlingX added a commit to BowlingX/jquery.dfp.js that referenced this issue Feb 20, 2017
…f data type can't be guessed correctly by jquery or a parsing error occurs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants