Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies - move nette to optional dependencies #62

Open
f3l1x opened this issue May 26, 2017 · 1 comment
Open

Dependencies - move nette to optional dependencies #62

f3l1x opened this issue May 26, 2017 · 1 comment
Assignees
Milestone

Comments

@f3l1x
Copy link
Member

f3l1x commented May 26, 2017

I'm also thinking about make this package thin as possible.

nette/application

Only usage is to create RedirectResponse, I vote for remove it a return only $url.

https://github.com/Markette/Gopay/blob/9a712df2cba8387a4b8c489bae44f2f8154037a5/src/Gopay/Service/PreAuthorizedPaymentService.php#L52

nette/forms

It is for bind some buttons/inputs to nette forms, but I don't use it and maybe other guys neither. So I vote for make it optional via require-dev.

nette/di

It's pretty standard and I don't see any reason to not include it.


cc @haltuf @hranicka @Attanon

@f3l1x f3l1x self-assigned this May 26, 2017
@f3l1x f3l1x added this to the v4.0.0 milestone May 26, 2017
@haltuf
Copy link
Contributor

haltuf commented May 26, 2017

ad nette/application: OK

ad nette/forms: never used this function, don't know what good could it be fore, to be honest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants