Code style

Author: aschempp

api/Task/AbstractTask.php

@@ -79,7 +79,11 @@ public function update(TaskConfig $config, bool $continue = false): TaskStatus
                     continue;
                 }
 
-                if ($operations[$i+1]?->isRunning() || $operations[$i+1]?->isSuccessful()) {
+                if (
+                    !isset($operations[$i + 1])
+                    || $operations[$i + 1]->isRunning()
+                    || $operations[$i + 1]->isSuccessful()
+                ) {
                     continue;
                 }
             }

api/Task/TaskStatus.php

@@ -123,8 +123,9 @@ public function getStatus(): string
                 if (
                     $operation->continueOnError()
                     && (
-                        $this->operations[$i + 1]?->isRunning()
-                        || $this->operations[$i + 1]?->isSuccessful()
+                        !isset($this->operations[$i + 1])
+                        || $this->operations[$i + 1]->isRunning()
+                        || $this->operations[$i + 1]->isSuccessful()
                     )
                 ) {
                     continue;

api/TaskOperation/Contao/MaintenanceModeOperation.php

@@ -33,6 +33,11 @@ public function getSummary(): string
         return 'vendor/bin/contao-console contao:maintenance-mode '.$this->state;
     }
 
+    public function continueOnError(): bool
+    {
+        return true;
+    }
+
     protected function getName(): string
     {
         return 'maintenance-'.$this->state;
@@ -50,9 +55,4 @@ protected function doRun(): bool
 
         return $process->isSuccessful();
     }
-
-    public function continueOnError(): bool
-    {
-        return true;
-    }
 }

rector.php

@@ -12,6 +12,7 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
 use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector;
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
 use Rector\Set\ValueObject\LevelSetList;
@@ -37,6 +38,7 @@
     ->withSkip([
         __DIR__.'/downgrade.php',
         __DIR__.'/stub.php',
+        ChangeOrIfContinueToMultiContinueRector::class,
         CatchExceptionNameMatchingTypeRector::class,
         ReturnBinaryOrToEarlyReturnRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,