Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated documentation: slirp4netns vs pasta #22543

Closed
lahwaacz opened this issue Apr 30, 2024 · 6 comments · Fixed by #22594
Closed

Outdated documentation: slirp4netns vs pasta #22543

lahwaacz opened this issue Apr 30, 2024 · 6 comments · Fixed by #22594
Assignees
Labels
documentation Issue or fix is in project documentation Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug.

Comments

@lahwaacz
Copy link

Issue Description

podman-network.1.md says that slirp4netns is the default network program for rootless containers.

However, containers.conf.5.md has default_rootless_network_cmd="pasta" by default.

Steps to reproduce the issue

Read the latest man pages 😄

Describe the results you received

Outdated documentation

Describe the results you expected

Documentation should be up to date

podman info output

(irrelevant)

Podman in a container

No

Privileged Or Rootless

Rootless

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

@lahwaacz lahwaacz added the kind/bug Categorizes issue or PR as related to a bug. label Apr 30, 2024
@Luap99 Luap99 added documentation Issue or fix is in project documentation Good First Issue This issue would be a good issue for a first time contributor to undertake. labels Apr 30, 2024
@Luap99
Copy link
Member

Luap99 commented Apr 30, 2024

Contributions welcome

@radar07
Copy link
Contributor

radar07 commented May 1, 2024

@Luap99 Can I work on this?

@Luap99
Copy link
Member

Luap99 commented May 2, 2024

@radar07 sure

@radar07
Copy link
Contributor

radar07 commented May 3, 2024

@Luap99 I wonder if we have to write a brief description about pasta as the default rootless network in place of slirp4netns in the man page. Do you have any suggestions?

@Luap99
Copy link
Member

Luap99 commented May 3, 2024

Yes that would be good, pasta works a bit differently so adding it there would be good. Maybe the pasta section here could serve as a string point: https://blog.podman.io/2024/03/podman-5-0-breaking-changes-in-detail/

The default is also wrong in https://github.com/containers/podman/blob/main/docs/source/markdown/options/network.md

@radar07
Copy link
Contributor

radar07 commented May 3, 2024

@Luap99, Thanks for letting me know. I created a PR with few changes that might get this done. Also, please let me know if you have any other suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or fix is in project documentation Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants