Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image history issues #3019

Open
apostasie opened this issue May 18, 2024 · 1 comment
Open

image history issues #3019

apostasie opened this issue May 18, 2024 · 1 comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim

Comments

@apostasie
Copy link
Contributor

apostasie commented May 18, 2024

Description

This ticket is meant to list all current issues with nerdctl image history when compared with docker image history.

    1. fails if multiple tags point to the same image
    1. outputs spurious "Snapshot" property
    • We can just remove this - or leave it if it serves a purpose.
    1. does not has "CreatedAt"
    • Easy to do, as we already have the info (used for CreatedSince)
    1. size formatting leaves to be desired:
    • spurious space between number and unit "XXX B"

    • does not strip irrelevant digits (eg: 0.0 B)

    • Responsible package is in containerd (progress/humaans.go), which actually uses docker/go-units under the hood.

    • We are using it a few other places.

    • We could just drop the intermediary dependency and use go-units directly for better display.

    1. does not list ID
    1. fails when using "format" and "quiet" together
    1. does not implement the "human" flag - and overall doesn't display local time
    1. "Snapshot" takes a lot of space with the table display, and should be truncated unless --no-trunc or --quiet

Steps to reproduce the issue

For 1:

nerdctl pull debian
nerdctl tag debian testtag
nerdctl image history fac2c0fd33e8

> FATA[0000] 1 errors:
multiple IDs found with provided prefix: fac2c0fd33e8

For 2:

nerdctl image history debian | jq .Snapshot

For 3:

nerdctl image history debian | jq .CreatedAt

For 4:

nerdctl image history debian | jq .Size

For 5:

nerdctl image history debian | jq .ID

For 6:

nerdctl image history --format json --quiet debian

Describe the results you received and expected

Expect to behave like docker.

I will send a PR that fixes the easy / non-controversial ones.
Let me know what you think about the other ones.

Thanks.

What version of nerdctl are you using?

1.7.6

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

@apostasie
Copy link
Contributor Author

Some of the issues fixed by #3020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim
Projects
None yet
Development

No branches or pull requests

1 participant