Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for msec time interval in Events #53

Open
ChethanSuresh opened this issue Aug 3, 2019 · 0 comments · May be fixed by #104
Open

Support for msec time interval in Events #53

ChethanSuresh opened this issue Aug 3, 2019 · 0 comments · May be fixed by #104

Comments

@ChethanSuresh
Copy link

runc events supports time intervals for msec. Example

# runc events --interval 0.5s <id>

The below line converts millisecond time.Duration API call to int, making the interval 0. Thus nil Events channel

go-runc/runc.go

Line 352 in 9007c24

cmd := r.command(context, "events", fmt.Sprintf("--interval=%ds", int(interval.Seconds())), id)

Is there any specific reason?
@austinvazquez austinvazquez linked a pull request Oct 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix interval parsing for runc events. austinvazquez/go-runc
1 participant
@ChethanSuresh