Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make STR field optional in lookup and monitoring response #181

Open
vqhuy opened this issue Aug 4, 2017 · 0 comments
Open

Make STR field optional in lookup and monitoring response #181

vqhuy opened this issue Aug 4, 2017 · 0 comments
Labels
protocol spec str
Milestone
0.2.0

Comments

@vqhuy
Copy link
Member

vqhuy commented Aug 4, 2017

Towards #173

  • Client gets STRs first, then lookup or monitoring
    => Use separate responses for STRs and other protocols

We should make STR field optional in DirectoryResponse struct.
@vqhuy vqhuy added this to the 0.2.0 milestone Aug 4, 2017
vqhuy added a commit that referenced this issue Oct 25, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
787fac7 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
@vqhuy vqhuy mentioned this issue Oct 25, 2017
Open
vqhuy added a commit that referenced this issue Oct 26, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
842fb4a 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Oct 26, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
5e983af 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Oct 27, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
466a496 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Oct 28, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
494cb36 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Oct 28, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
3bfd090 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Dec 20, 2017
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
edb358d 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
vqhuy added a commit that referenced this issue Jan 10, 2018
@vqhuy
* Remove STR field from DirectoryResponse (Close #181)
529d97f 
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic

* Comment some tests which will be rewritten later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol spec str
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@vqhuy