Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVariableValues: unhandled errors #226

Open
Poweranimal opened this issue Feb 26, 2024 · 0 comments · May be fixed by #229
Open

getVariableValues: unhandled errors #226

Poweranimal opened this issue Feb 26, 2024 · 0 comments · May be fixed by #229
Labels
bug Something isn't working

Comments

@Poweranimal
Copy link

Poweranimal commented Feb 26, 2024

Hi,

The possibly returned error from graphql.getVariableValues is unhandled.
See here: query-validation-visitor.js

This unhandled error causes serious side effects.

E.g.:
A query with variables has been submitted.
Getting the variables fails because of some reason (e.g. 'Cannot use GraphQLScalarType "Int" from another module or realm.\n\nEnsure that there is only one instance of "graphql" in the node_modules\ndirectory. If different versions of "graphql" are the dependencies of other\nrelied on modules, use "resolutions" to ensure only one version is installed.\n\nhttps://yarnpkg.com/en/docs/selective-version-resolutions\n\nDuplicate "graphql" modules cannot be used at the same time since different\nversions may have different capabilities and behavior. The data from one\nversion used in the function from another could produce confusing and\nspurious results.')
The returned result is undefined.
All passed variables of the query do not get validated.

Isues found because of: #225

@Poweranimal Poweranimal linked a pull request Mar 6, 2024 that will close this issue
@confuser confuser added the bug Something isn't working label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants