Fix type definition issues in the constructors (#321)

* Update kafkajs.d.ts

constructor config mark as optional properly

* Add type definition fixes

* Add PR number

---------

Co-authored-by: David Liu <[email protected]>

Author: milindl

CHANGELOG.md

@@ -4,9 +4,11 @@ v1.3.1 is a maintenance release. It is supported for all usage.
 
 ## Fixes
 
-1. Avoid a race condition that causes 100% usage of a CPU core when 
+1. Avoid a race condition that causes 100% usage of a CPU core when
    consuming with `partitionsConsumedConcurrently > 1` and all messages
    are consumed (#300)
+2. Fix type definition for `Kafka()` constructor and for passing topic configurations
+   to the `producer()` and `consumer()` in the promisified API (@davidkhala, #297, #321).
 
 
 # confluent-kafka-javascript v1.3.0

types/kafkajs.d.ts

@@ -1,4 +1,9 @@
-import { ConsumerGlobalConfig, GlobalConfig, ProducerGlobalConfig } from './config'
+import {
+  ConsumerGlobalConfig,
+  ConsumerTopicConfig,
+  GlobalConfig,
+  ProducerGlobalConfig,
+  ProducerTopicConfig } from './config'
 import {
   ConsumerGroupStates,
   GroupOverview,
@@ -94,7 +99,7 @@ export interface CommonConstructorConfig extends GlobalConfig {
 }
 
 export class Kafka {
-  constructor(config: CommonConstructorConfig)
+  constructor(config?: CommonConstructorConfig)
   producer(config?: ProducerConstructorConfig): Producer
   consumer(config: ConsumerConstructorConfig): Consumer
   admin(config?: AdminConstructorConfig): Admin
@@ -131,7 +136,9 @@ export interface ProducerConfig {
   logger?: Logger,
 }
 
-export interface ProducerConstructorConfig extends ProducerGlobalConfig {
+type ProducerGlobalAndTopicConfig = ProducerGlobalConfig & ProducerTopicConfig;
+
+export interface ProducerConstructorConfig extends ProducerGlobalAndTopicConfig {
   kafkaJS?: ProducerConfig;
 }
 
@@ -235,7 +242,9 @@ export interface ConsumerConfig {
   partitionAssignors?: PartitionAssignors[],
 }
 
-export interface ConsumerConstructorConfig extends ConsumerGlobalConfig {
+export type ConsumerGlobalAndTopicConfig = ConsumerGlobalConfig & ConsumerTopicConfig;
+
+export interface ConsumerConstructorConfig extends ConsumerGlobalAndTopicConfig {
   kafkaJS?: ConsumerConfig;
 }