Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package badges do not exclude broken releases #737

Open
2 tasks done
tpdownes opened this issue Mar 30, 2023 · 4 comments
Open
2 tasks done

Package badges do not exclude broken releases #737

tpdownes opened this issue Mar 30, 2023 · 4 comments
Labels
stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type

Comments

@tpdownes
Copy link

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Recently, the Google protobuf repository changed its versioning scheme such that the repo is tagged with, e.g. 22.2, but the specific language implementations in the repo may have a major version prepended. e.g. the Python release is 4.22.2.

During this transition conda-forge released a version 21.2 of the package. This problem was reported and the packages marked broken. Nevertheless, badges report the 21.2 release as the highest available on conda-forge. It doesn't seem right to include broken packages in this calculation.

I understand that the upstream badge reports 22.2 and that may not have a good, generalizable solution. I'm focusing on the channel badge.

Conda Info

active environment : default
    active env location : /Users/tpdownes/local/miniconda3/envs/default
            shell level : 1
       user config file : /Users/tpdownes/.condarc
 populated config files : /Users/tpdownes/local/miniconda3/.condarc
                          /Users/tpdownes/.condarc
          conda version : 23.1.0
    conda-build version : not installed
         python version : 3.10.9.final.0
       virtual packages : __archspec=1=x86_64
                          __osx=13.2.1=0
                          __unix=0=0
       base environment : /Users/tpdownes/local/miniconda3  (writable)
      conda av data dir : /Users/tpdownes/local/miniconda3/etc/conda
  conda av metadata url : None
           channel URLs : https://conda.anaconda.org/conda-forge/osx-64
                          https://conda.anaconda.org/conda-forge/noarch
          package cache : /Users/tpdownes/local/miniconda3/pkgs
                          /Users/tpdownes/.conda/pkgs
       envs directories : /Users/tpdownes/local/miniconda3/envs
                          /Users/tpdownes/.conda/envs
               platform : osx-64
             user-agent : conda/23.1.0 requests/2.28.2 CPython/3.10.9 Darwin/22.3.0 OSX/13.2.1
                UID:GID : 828971:89939
             netrc file : None
           offline mode : False

Conda Config

==> /Users/tpdownes/local/miniconda3/.condarc <==
channels: []

==> /Users/tpdownes/.condarc <==
auto_activate_base: False
changeps1: False
create_default_packages:
  - coreutils
default_threads: 5
channel_priority: strict
channels:
  - conda-forge

Conda list

No response

Additional Context

No response

@tpdownes tpdownes added the type::bug describes erroneous operation, use severity::* to classify the type label Mar 30, 2023
@tpdownes
Copy link
Author

Was advised by conda-forge/protobuf-feedstock#181 to file an issue in this repo.

Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Mar 30, 2024
@jakirkham
Copy link
Member

This is still an issue

@jakirkham
Copy link
Member

@jezdez is this something we could look into?

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants