-
-
Notifications
You must be signed in to change notification settings - Fork 78
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
grayskull cran makes multiple mistakes when configuring the recipe requirements for an R package on CRAN:
- The names are not lowercase (eg the conda package is
r-rcppnotr-Rcpp) - Packages listed in
Dependsare ignored - Packaged listed in
LinkingToare ignored - Packages included with
r-baseare listed (these packages do not exist on anaconda.org), egr-stats,r-tools,r-utils, etc.
To Reproduce
I discovered the problems above when generating a recipe for the R package SeuratObject:
curl https://cran.r-project.org/web/packages/SeuratObject/DESCRIPTION
## Depends: R (>= 4.1.0), sp (>= 1.5.0)
## Imports: future, future.apply, generics, grDevices, grid, lifecycle,
## Matrix (>= 1.6.4), methods, progressr, Rcpp (>= 1.0.5), rlang
## (>= 0.4.7), spam, stats, tools, utils
## Suggests: BPCells, DelayedArray, fs (>= 1.5.2), ggplot2, HDF5Array,
## rmarkdown, sf (>= 1.0.0), testthat
## LinkingTo: Rcpp, RcppEigen
grayskull --version
## 2.9.1
grayskull cran --strict-conda-forge r-seuratobject
## host:
## - r-Matrix >=1.6.4
## - r-Rcpp >=1.0.5
## - r-base
## - r-future
## - r-future.apply
## - r-generics
## - r-grDevices
## - r-grid
## - r-lifecycle
## - r-methods
## - r-progressr
## - r-rlang >=0.4.7
## - r-spam
## - r-stats
## - r-tools
## - r-utils
rm -r r-seuratobject/
conda build --version
## conda-build 25.4.2
conda skeleton cran --use-noarch-generic --add-cross-r-base --no-comments --allow-archived r-seuratobject
## host:
## - r-base
## - r-matrix >=1.6.4
## - r-rcpp >=1.0.5
## - r-rcppeigen
## - r-future
## - r-future.apply
## - r-generics
## - r-lifecycle
## - r-progressr
## - r-rlang >=0.4.7
## - r-sp >=1.5.0
## - r-spamExpected behavior
Should return the same requirements as conda skeleton cran
Environment:
Versions of grayskull and conda-build included above
Additional context
xref: #615, bgruening/conda_r_skeleton_helper#58, bgruening/conda_r_skeleton_helper#68
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working