-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] about.home defaults to None instead of PyPI project page #447
Comments
Another similar case: grayskull pypi mkdocs-include-markdown-plugin generates a This results in a complaint by the linter: conda-forge/staged-recipes#22080 (comment) |
hey there @maresb and grayskull maintainers 👋 i was just looking into this myself. Something is a bit odd with grayskull. I have been testing this for our tutorials. And no matter what i add to my pyproject.toml file it seems like [project.urls]
Homepage = "https://pypi.org/project/pyospackage/"
Documentation = "https://github.com/pyopensci/pyospackage#readme"
Issues = "https://github.com/pyopensci/pyospackage/issues"
Source = "https://github.com/pyopensci/pyospackage" as a result the conda-linter bot (very friendly!!) tells me something is wrong with my recipe. i can absolutely add
This is what i get in the about section: about:
summary: A package that adds numbers together
dev_url: https://github.com/pyopensci/pyospackage
license: MIT
license_file: LICENSE i think for now i'll tell folks to add home = manually but i wondered if someone could help us understand if this is actually a bug OR something that I am missing when running grayskull. thank you for making this tool as it's takes a lot of the confusion around creating a recipe away! For a pure python package i'd just hope it worked out of the box and gave the linter everything that it needs to pass a build! |
Hi @lwasser, this is definitely a bug. There's some seemingly overcomplicated logic for merging the various data sources. It looks like there may be typos in the names. It would be really nice to add validation, e.g. with a type checker. That would prevent these sorts of problems, but adding that would unfortunately be quite a lot of work. I attempted a quick fix in #525, but unfortunately my changes broke other stuff. |
Describe the bug
Without a PyPI "homepage" URL on PyPI, the key
about.home
defaults toNone
.To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would have expected it to be
https://pypi.org/project/{{ name }}
.Environment:
The text was updated successfully, but these errors were encountered: