Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how NSIS amends PATH on Windows #623

Open
jaimergp opened this issue Jan 23, 2023 · 1 comment
Open

Fix how NSIS amends PATH on Windows #623

jaimergp opened this issue Jan 23, 2023 · 1 comment
Labels
os::windows relevant to Windows stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity

Comments

@jaimergp
Copy link
Contributor

https://nsis.sourceforge.io/Setting_Environment_Variables has a big warning about this:

WARNING: Strings longer than ${NSIS_MAX_STRLEN} will get truncated/corrupted. Do NOT use this function to update %PATH%, use the EnVar_plug-in instead.

... and that's how it's being done right now. Unclear if $INSTDIR and $0 get expanded for the count, but I assume they do and on (very?) long paths, this might be an issue. This is worth an investigation and, if we need this, we would have to add the EnVar plugin to the nsis builds on conda-forge and defaults.

@jaimergp jaimergp added the os::windows relevant to Windows label Jan 23, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Jan 24, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Feb 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Feb 24, 2024
@jaimergp jaimergp reopened this Feb 25, 2024
@github-project-automation github-project-automation bot moved this from 🏁 Done to 🏗️ In Progress in 🧭 Planning Feb 25, 2024
@jaimergp jaimergp added stale::recovered [bot] recovered after being marked as stale and removed stale::closed [bot] closed after being marked as stale labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os::windows relevant to Windows stale::recovered [bot] recovered after being marked as stale stale [bot] marked as stale due to inactivity
Projects
Status: 🏗️ In Progress
Development

No branches or pull requests

1 participant