fix: allow tuples, lists and dicts in selectors (#5690)

* fix: allow tuples, lists and dicts in selectors

* test: add test for selectors with tuples, lists, dicts

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* doc: add news item

* fix: list literals do not work, but test node via function

* test: add snippet of cfp

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: beckermr

conda_build/metadata.py

@@ -289,7 +289,7 @@ def parseNameNotFound(error) -> str:
 @cache
 def evalidate_model():
     model = base_eval_model.clone()
-    model.nodes.extend(["Call", "Attribute"])
+    model.nodes.extend(["Call", "Attribute", "Tuple", "List", "Dict"])
     model.allowed_functions += [
         "int",
         "str",

news/5690-selector-lists.rst

@@ -0,0 +1,19 @@
+### Enhancements
+
+* <news item>
+
+### Bug fixes
+
+* Fixed bug where selectors with lists, tuples, or dicts could not be processed. (#5690)
+
+### Deprecations
+
+* <news item>
+
+### Docs
+
+* <news item>
+
+### Other
+
+* <news item>

tests/test_metadata.py

@@ -5,6 +5,7 @@
 import os
 import subprocess
 import sys
+import textwrap
 from contextlib import nullcontext
 from itertools import product
 from typing import TYPE_CHECKING
@@ -63,6 +64,20 @@ def test_uses_vcs_in_metadata(testing_workdir, testing_metadata):
     assert not testing_metadata.uses_vcs_in_build
 
 
+def test_select_lines_complicated_smoke():
+    # this snippet is from the conda-forge pinnings file
+    cfpinning = textwrap.dedent(
+        """
+        docker_image:                                       # [os.environ.get("BUILD_PLATFORM", "").startswith("linux-")]
+        # non-CUDA-enabled builds on AlmaLinux 8
+        - quay.io/condaforge/linux-anvil-x86_64:alma8     # [os.environ.get("BUILD_PLATFORM") == "linux-64" and os.environ.get("DEFAULT_LINUX_VERSION", "alma9") in ("alma8", "ubi8")]
+        - quay.io/condaforge/linux-anvil-aarch64:alma8    # [os.environ.get("BUILD_PLATFORM") == "linux-aarch64" and os.environ.get("DEFAULT_LINUX_VERSION", "alma9") in ("alma8", "ubi8")]
+        - quay.io/condaforge/linux-anvil-ppc64le:alma8    # [os.environ.get("BUILD_PLATFORM") == "linux-ppc64le" and os.environ.get("DEFAULT_LINUX_VERSION", "alma9") in ("alma8", "ubi8")]
+        """  # noqa: E501
+    )
+    select_lines(cfpinning, {"os": OSModuleSubset}, variants_in_place=True)
+
+
 def test_select_lines():
     lines = "\n".join(
         (
@@ -83,11 +98,16 @@ def test_select_lines():
             "test {{ JINJA_VAR[:2] }} # stuff yes [abc]",
             "test {{ JINJA_VAR[:2] }} # [abc] stuff yes",
             '{{ environ["test"] }}  # [abc]',
+            '{{ environ["test-tuple"] }}  # [d in ("a", "b")]',
+            '{{ environ["test-list"] }}  # [d in list(("a", "b"))]',
+            '{{ environ["test-dict"] }}  # [d in {"a": 1, "b": 2}]',
             "",  # preserve trailing newline
         )
     )
 
-    assert select_lines(lines, {"abc": True}, variants_in_place=True) == "\n".join(
+    assert select_lines(
+        lines, {"abc": True, "d": "b"}, variants_in_place=True
+    ) == "\n".join(
         (
             "",  # preserve leading newline
             "test",
@@ -106,10 +126,15 @@ def test_select_lines():
             "test {{ JINJA_VAR[:2] }}",
             "test {{ JINJA_VAR[:2] }}",
             '{{ environ["test"] }}',
+            '{{ environ["test-tuple"] }}',
+            '{{ environ["test-list"] }}',
+            '{{ environ["test-dict"] }}',
             "",  # preserve trailing newline
         )
     )
-    assert select_lines(lines, {"abc": False}, variants_in_place=True) == "\n".join(
+    assert select_lines(
+        lines, {"abc": False, "d": "c"}, variants_in_place=True
+    ) == "\n".join(
         (
             "",  # preserve leading newline
             "test",