Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/build/script needs to be upgraded #64

Closed
schuylermartin45 opened this issue May 22, 2024 · 0 comments · Fixed by #65
Closed

/build/script needs to be upgraded #64

schuylermartin45 opened this issue May 22, 2024 · 0 comments · Fixed by #65
Labels
v0 to v1 recipe conversion Issues with our v0 -> v1 recipe upgrade tooling

Comments

@schuylermartin45
Copy link
Collaborator

The /build/script section is currently not being upgraded. In simple scenarios, this works out fine. In complex situations, we need to use the new Script object

This will be a pretty involved upgrade process that will need to be heavily conditionalized. From a brief search, there are already many variants AND we have to parse-out shell variable syntax in the existing script_env field.

@schuylermartin45 schuylermartin45 added the v0 to v1 recipe conversion Issues with our v0 -> v1 recipe upgrade tooling label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0 to v1 recipe conversion Issues with our v0 -> v1 recipe upgrade tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant