Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #54

Open
ocefpaf opened this issue Jul 30, 2019 · 6 comments
Open

Rename package #54

ocefpaf opened this issue Jul 30, 2019 · 6 comments

Comments

@ocefpaf
Copy link
Member

ocefpaf commented Jul 30, 2019

Looks like the package was renamed to tables in PyPI and this is creating some confusion for some users. Should we rename it here too? See https://pypi.org/project/tables/#files

@tomkooij
Copy link
Contributor

It has always been tables in PyPI and pytables on (ana)conda. Renaming this here would IMO add to the confusion. (And break existing environment.yml)

I suggest sticking to the current pytables.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 30, 2019

Not necessarily. We can add an "alias" package.

@tomkooij
Copy link
Contributor

tomkooij commented Jul 31, 2019

Not necessarily. We can add an "alias" package.

Ok! I'm not sure which is better:

  • A) pytables-feedstock with tables as an alias (which fits with pytables repo and pytables-wheels for wheel building`) : This is more congruent on for devs.
  • B) tables-feedstock with pytables as an alias (conda install tables vs pip install tables) : This is more congruent for users.

Option B is better for users I guess. Sinces I'm looking at this more from the dev standpoint I tend to favour option A.

If there is a conda policy to keep names congruent with PyPI, perhaps to avoid package conflicts when using pip in a conda-env, then option B is certainly better.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 31, 2019

@msarahan are there any fancy tricks with multiple outputs that we can use here to create both pytables and tables packages?

@msarahan
Copy link
Member

sure, just make a metapackage that depends on the "real" one. We do that in our boost recipe to adapt to conda-forge's names: https://github.com/AnacondaRecipes/boost-feedstock/blob/master/recipe/meta.yaml#L174

@ocefpaf
Copy link
Member Author

ocefpaf commented Jul 31, 2019

Awesome! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants