ccm_paging_p Included Querystring Parameter

[ccmEnlil]

Affected Version of Concrete CMS

9.x

Description

I'm working with and interested in creating a pull request to add the following method to the SEOCanonical class https://github.com/concretecms/concretecms/blob/9.1.1/concrete/src/Url/SeoCanonical.php

public function getIncludedQuerystringParameters()
{
return $this->includedQuerystringParameters;
}

This gets an array of the querystring keys for the active page (Core Page List Blocks on page 2 or greater). Works nicely, except the first key in the returned list is ALWAYS ccm_paging_p.

If I change the paging variable in config, keys included by the core page list block will look like custom_paging_b123 when returned, while the first key in the list will still be ccm_paging_p, leaving no included key for custom_paging.

How to reproduce

Change paging variable in config. Then implement this method, or similar, and call it. Any given page will always return ccm_paging_p, with or without additional page list paging parameters included.

Possible Solution

I believe this happens because ccm_paging_p is hard wired in config. We should possibly be doing this elsewhere based on the paging config value for concrete.seo.paging_string ?

Additional Context

No response

[ccmEnlil]

Currently, the above scenario can be visually evidenced (key array output included) by paging the list at the bottom of the page at https://juspimpin.com

[ccmEnlil]

I believe this is where this issue was introduced. @hissy maybe you have some input on this? https://github.com/concretecms/concretecms/pull/10379/files#diff-fef25135059f7be97d60df4a153febebdbb4591dade83578156c320f023b7869R147

[ccmEnlil]

Just tested this against the search block. My seo paging string is set to "custom_paging". When paging the search block it utilizes "custom_paging" for the querystring key, but it isn't allowed because of the above issue, so the canonical url in page output does not have the attached querystring.