Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Guest Access doesn't work without a start date #12012

Open
moriaiy opened this issue Apr 4, 2024 · 1 comment
Open

Schedule Guest Access doesn't work without a start date #12012

moriaiy opened this issue Apr 4, 2024 · 1 comment
Labels
Bug:Level of Effort:Low Bugs that likely require a day or less to fix, and where the path to the fix is already known. Bug:Reproduceable:Yes Able to reproduce the bug. Product Areas:Permissions & Workflow Type:Bug Existing functionality not performing as expected.

Comments

@moriaiy
Copy link

moriaiy commented Apr 4, 2024

Affected Version of Concrete CMS

8.5.x, 9.x

Description

In Schedule Guest Access, the three blocks were set up as follows:

  1. Set both Start and End Date.
  2. Set only Start Date.
  3. Set only End Date.

When I check with the guest user, only the End Date is set (No. 3) is not displayed.
Other settings displayed.

Setting the Start Date would work around the problem.
However, it would be nice to be able to display the case where only the End Date is set.

How to reproduce

Settings

  1. Set both Start and End Date.(From: 4/4/2024, To: 4/30/2024)
  2. Set only Start Date.(From: 4/4/2024, To: none)
  3. Set only End Date.(From: none, To: 4/30/2024)

image

Result
image

Possible Solution

No response

Additional Context

No response

@moriaiy moriaiy added the Type:Bug Existing functionality not performing as expected. label Apr 4, 2024
@aembler aembler added Product Areas:Permissions & Workflow Bug:Level of Effort:Low Bugs that likely require a day or less to fix, and where the path to the fix is already known. Bug:Reproduceable:Yes Able to reproduce the bug. labels May 21, 2024
@aembler
Copy link
Member

aembler commented May 21, 2024

This is fairly easy to fix – the problem is the getActiveRange method of AbstractRepetition returns null if there's no start date – but I'm a little worried about making that change without causing unintended consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:Level of Effort:Low Bugs that likely require a day or less to fix, and where the path to the fix is already known. Bug:Reproduceable:Yes Able to reproduce the bug. Product Areas:Permissions & Workflow Type:Bug Existing functionality not performing as expected.
Projects
None yet
Development

No branches or pull requests

2 participants