You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the removal of the console proxy, and the restoration of the react-router specific error handling (for clearing the canvas after an internal error boundary is triggered) in #5682, the canvas now requires an extra interaction (e.g. scrolling or making another change to the code file, or even saving the code file) before the canvas reset is actually applied (check the video linked in that PR).
After a short investigation I narrowed this down to being caused by the way we update the mount count at the very end of the dispatch (via a mutation)
Updating the mount count by clicking the reset canvas button in the toolbar still correctly causes the canvas to re-render
If we update both the patched and unpatched editor states with the new mount count in the above code then the error boundary persists even after further interactions
The mount count is definitely updated after the error is shown, but the updated value isn't read when pickUiJsxCanvasProps is called (hence why the canvas doesn't actually reset)
The text was updated successfully, but these errors were encountered:
With the removal of the console proxy, and the restoration of the react-router specific error handling (for clearing the canvas after an internal error boundary is triggered) in #5682, the canvas now requires an extra interaction (e.g. scrolling or making another change to the code file, or even saving the code file) before the canvas reset is actually applied (check the video linked in that PR).
After a short investigation I narrowed this down to being caused by the way we update the mount count at the very end of the dispatch (via a mutation)
utopia/editor/src/components/editor/store/dispatch.tsx
Lines 730 to 735 in f53d182
pickUiJsxCanvasProps
is called (hence why the canvas doesn't actually reset)The text was updated successfully, but these errors were encountered: