Parse destructuring of assignment statements. #5483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We need more detail in the assignment statements so that we can track destructuring.
Fix:
We already have
Param
and some associated types which handle the destructuring for function parameters and the TypeScript compiler uses the same underlying representation in both cases (function parameters and variable declarations). As a result in this we use that existing functionality to handle the same type of parsing for the variable declarations.Commit Details:
JSAssignment.leftHandSide
to be an instance ofBoundParam
.Param
related fields fromJSExpressionMapOrOtherJavascript
toJSExpression
.clearArbitraryJSBlockSourceMaps
,clearDestructuredArrayPartSourceMaps
,clearDestructuredParamPartSourceMaps
,clearParamSourceMaps
,clearBoundParamSourceMaps
,clearBoundParamUniqueIDsAndSourceMaps
,clearTopLevelElementSourceMaps
,clearJSAssignmentSourceMaps
,clearJSArbitraryStatementSourceMaps
,clearParseResultSourceMapsUniqueIDsAndEmptyBlocks
andclearTopLevelElementSourceMapsUniqueIDsAndEmptyBlocks
utility functions.parseDeclaration
now usesparseBindingName
to produce the expected representation forJSAssignment
values.lookupIntoComponentScope
.Manual Tests:
I hereby swear that: