Skip to content

Default disable_ci_skip to true #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-baylibre opened this issue Apr 2, 2024 · 1 comment
Open

Default disable_ci_skip to true #426

david-baylibre opened this issue Apr 2, 2024 · 1 comment

Comments

@david-baylibre
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I think it would make sense to change disable_ci_skip default value to true for the following reasons:

  • All filters are empty by default, disable_ci_skip introduces a filter in some way.
  • On top of that, people do not benefit from PR fast check skipping repo download #425 which makes checks run instantly (skipping repo download), unless they set disable_ci_skip to true.

Describe the solution you'd like

Default disable_ci_skip variable to true

  • OR -

Rename disable_ci_skip variable to enable_ci_skip (with default value set to false obviously)

Describe alternatives you've considered

No response

Additional context

I'd be happy to make a patch

@taylorsilva
Copy link
Member

It would be nice to make this the default, but it will definitely break things for people who rely on the current default behaviour.

If you want to make this the default on your cluster you can take advantage of this feature: concourse/concourse#6079

So that way at least on your cluster, all git resources have disable_ci_skip set to `true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants