archive pipeline leaks containers

[fredwangwang]

Summary

Hi, I am using set-pipeline step to dynamically create/tear down pipelines for feature branches.

After using the feature for a while noticing new pipelines hitting issues with worker no longer able to create new containers due to the workers has reached max number of containers.

using fly containers reveals a bunch dangling containers for the instance pipelines that has already archived.

below shows one such container after the instance has been archived

Steps to reproduce

setting up multi branch workflow per: https://concourse-ci.org/multi-branch-workflows.html#multi-branch-tracking-branches,
then remove a branch.

OR I think manually set-pipeline and archive-pipeline could also trigger, but havent tested myself.

Expected results

Containers associated with archived pipeline are destroyed

Actual results

Containers associated with archived pipeline are leaked

Triaging info

• Concourse version: 7.10.0
• Did this used to work? Dont think so