Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview gh action #34

Open
asmacdo opened this issue Dec 7, 2022 · 10 comments
Open

Add preview gh action #34

asmacdo opened this issue Dec 7, 2022 · 10 comments

Comments

@asmacdo
Copy link
Member

asmacdo commented Dec 7, 2022

On PR, build a tmp site so we can see changes without building locally.

@yarikoptic
Copy link
Member

well, if we used RTD -- we could do eat easily. But ATM website is served from in-house web server, and build is a bit ad-hoc since not compatible with recent pelican. Do you know how it (previewzs) could be done without much struggle?

@yarikoptic
Copy link
Member

what about at least a CI run which would smoke test the build that it builds ok?

@yarikoptic
Copy link
Member

Wanna to take on @asmacdo ?

@asmacdo
Copy link
Member Author

asmacdo commented Jul 10, 2023

@yarikoptic sure-- I can't self-assign, can you add me to the repo?

@yarikoptic
Copy link
Member

oh, I added you to the repo with super powers now, and assigning now. Thanks!

@yarikoptic
Copy link
Member

may be we could use netlify here for open source hosting?

@asmacdo
Copy link
Member Author

asmacdo commented Jul 14, 2023

@asmacdo
Copy link
Member Author

asmacdo commented Jul 17, 2023

Response from netlify:

Hey @asmacdo,

This should still qualify. Please fill this up: oss-account-application (netlify.com) and feel free to link to this thread.

Its also worth considering using the same deploy system for preview/production. Perhaps we could deploy to a subdomain using our existing host?

Or, we could proceed with netlify for preview hosting, and if it goes well we could easily switch prod to them as well (free!)

@yarikoptic
Copy link
Member

FWIW: https://github.com/marketplace/actions/deploy-pr-preview could be used if we decide to move to gh-pages

@yarikoptic
Copy link
Member

if you think to go with netlify - please fill out that that form @asmacdo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants