Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we change the 'silent fail' if the system doesn't reach a relaxed state in max_steps? #118

Open
rpep opened this issue Jun 18, 2018 · 0 comments
Open

Should we change the 'silent fail' if the system doesn't reach a relaxed state in max_steps? #118

rpep opened this issue Jun 18, 2018 · 0 comments
Labels
enhancement

Comments

@rpep
Copy link
Member

rpep commented Jun 18, 2018

We could raise an exception if the system fails to relax if it hasn't reached stopping_dmdt in under max_steps. At the moment, we 'silently fail' which is not a great idea; it means that a user might think the system has relaxed when it has not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpep