Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None in psm_list['rescoring_features'] #192

Open
rodvrees opened this issue Sep 19, 2024 · 0 comments
Open

Handle None in psm_list['rescoring_features'] #192

rodvrees opened this issue Sep 19, 2024 · 0 comments

Comments

@rodvrees
Copy link
Member

At the moment, psm_utils' PepXMLReader reader passes by default:
rescoring_features = None

This gives the following error in MS2Rescore:

  File "/home/robbe/miniconda3/envs/rescore/lib/python3.10/site-packages/ms2rescore/__main__.py", line 237, in main
    rescore(configuration=config)
  File "/home/robbe/miniconda3/envs/rescore/lib/python3.10/site-packages/ms2rescore/core.py", line 55, in rescore
    psm_list_feature_names = {
  File "/home/robbe/miniconda3/envs/rescore/lib/python3.10/site-packages/ms2rescore/core.py", line 58, in <setcomp>
    for feature_name in psm_list_features.keys()
AttributeError: 'NoneType' object has no attribute 'keys'

None values should thus handle None values as empty lists for correct processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant