Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different levels of confidence estimates when using mokapot #112

Open
jonasscheid opened this issue Nov 28, 2023 · 2 comments
Open
Labels
feature new feature

Comments

@jonasscheid
Copy link

Currently PSMs are evaluated using psm-level FDR when using mokapot see here
Peptide-level confidence estimates are also present in the object mokapot returns. Would be of interest to give the user the freedom to choose the FDR-level

@RalfG
Copy link
Member

RalfG commented Nov 30, 2023

Agreed that this could be reported somehow. The main issue blocking this is that the (output) object in MS²Rescore is the PSM list, which has only PSM-level entries. Would you repeat each peptide/protein-level q-value and PEP for each PSM linked to these? Remaining issue then is how to deal with PSMs linked to multiple protein groups. Or am I missing something? Ideas are very much welcome!

@RalfG RalfG added the feature new feature label Nov 30, 2023
@jonasscheid
Copy link
Author

jonasscheid commented Nov 30, 2023

Would you repeat each peptide/protein-level q-value and PEP for each PSM linked to these?

Yes I had that also in mind! But for peptides mapping to multiple proteins that is indeed a tricky one..
One ad-hoc idea I have for protein-level fdr is to store a dict of proteins with the confidence estimates in provenance_data, but then again provenance_data : dict[str, str] so that is currently not possible. Maybe only support peptide-level-fdr for now? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants