linting

Author: jthrilly

.eslintrc.cjs

@@ -26,11 +26,17 @@ const config = {
     'next/core-web-vitals',
     'prettier',
   ],
-  ignorePatterns: ['node_modules', '*.stories.*', '*.test.*', 'public', '.eslintrc.cjs',],
+  ignorePatterns: [
+    'node_modules',
+    '*.stories.*',
+    '*.test.*',
+    'public',
+    '.eslintrc.cjs',
+  ],
   rules: {
-    "@next/next/no-img-element": "off",
-    "import/no-anonymous-default-export": "off",
-    "@typescript-eslint/consistent-type-definitions": ['error', 'type'],
+    '@next/next/no-img-element': 'off',
+    'import/no-anonymous-default-export': 'off',
+    '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
     'no-process-env': 'error',
     'no-console': 'error',
     '@typescript-eslint/consistent-type-imports': [
@@ -43,14 +49,15 @@ const config = {
     '@typescript-eslint/no-unused-vars': [
       'error',
       {
+        caughtErrors: 'none',
         argsIgnorePattern: '^_',
       },
     ],
-    "@typescript-eslint/no-misused-promises": [
-      "error",
+    '@typescript-eslint/no-misused-promises': [
+      'error',
       {
-        "checksVoidReturn": false
-      }
+        checksVoidReturn: false,
+      },
     ],
     'no-unreachable': 'error',
   },

.vscode/settings.json

@@ -7,6 +7,7 @@
   "WillLuke.nextjs.addTypesOnSave": true,
   "WillLuke.nextjs.hasPrompted": true,
   "editor.codeActionsOnSave": {
-    "source.organizeImports": "always"
+    "source.organizeImports": "always",
+    "source.fixAll": "always",
   }
 }

actions/activityFeed.ts

@@ -19,7 +19,7 @@ export async function addEvent(
     safeRevalidateTag('activityFeed');
 
     return { success: true, error: null };
-  } catch (error) {
+  } catch (_error) {
     return { success: false, error: 'Failed to add event' };
   }
 }

app/dashboard/_components/InterviewsTable/ActionsDropdown.tsx

@@ -4,6 +4,7 @@ import type { Interview } from '@prisma/client';
 import type { Row } from '@tanstack/react-table';
 import { MoreHorizontal } from 'lucide-react';
 import Link from 'next/link';
+import { objectHash } from 'ohash';
 import { useState } from 'react';
 import { DeleteInterviewsDialog } from '~/app/dashboard/interviews/_components/DeleteInterviewsDialog';
 import { ExportInterviewsDialog } from '~/app/dashboard/interviews/_components/ExportInterviewsDialog';
@@ -39,7 +40,7 @@ export const ActionsDropdown = ({ row }: { row: Row<Interview> }) => {
   return (
     <>
       <ExportInterviewsDialog
-        key={selectedInterviews?.toString()}
+        key={objectHash(selectedInterviews)}
         open={showExportModal}
         handleCancel={handleResetExport}
         interviewsToExport={selectedInterviews!}

app/dashboard/_components/InterviewsTable/InterviewsTable.tsx

@@ -1,6 +1,7 @@
 'use client';
 
 import { HardDriveUpload } from 'lucide-react';
+import { objectHash } from 'ohash';
 import { use, useMemo, useState } from 'react';
 import { ActionsDropdown } from '~/app/dashboard/_components/InterviewsTable/ActionsDropdown';
 import { InterviewColumns } from '~/app/dashboard/_components/InterviewsTable/Columns';
@@ -60,7 +61,7 @@ export const InterviewsTable = ({
   return (
     <>
       <ExportInterviewsDialog
-        key={selectedInterviews?.toString()}
+        key={objectHash(selectedInterviews)}
         open={showExportModal}
         handleCancel={handleResetExport}
         interviewsToExport={selectedInterviews!}

components/ProtocolImport/JobReducer.ts

@@ -1,15 +1,12 @@
 import trackEvent from '~/lib/analytics';
 
-const importStatuses = [
-  'Queued',
-  'Extracting protocol',
-  'Validating protocol',
-  'Uploading assets',
-  'Writing to database',
-  'Complete',
-] as const;
-
-type ImportStatus = (typeof importStatuses)[number];
+type ImportStatus =
+  | 'Queued'
+  | 'Extracting protocol'
+  | 'Validating protocol'
+  | 'Uploading assets'
+  | 'Writing to database'
+  | 'Complete';
 
 type ErrorState = {
   title: string;

components/ui/use-toast.ts

@@ -14,21 +14,19 @@ type ToasterToast = ToastProps & {
   icon?: React.ReactNode;
 };
 
-const actionTypes = {
-  ADD_TOAST: 'ADD_TOAST',
-  UPDATE_TOAST: 'UPDATE_TOAST',
-  DISMISS_TOAST: 'DISMISS_TOAST',
-  REMOVE_TOAST: 'REMOVE_TOAST',
-} as const;
-
 let count = 0;
 
 function genId() {
   count = (count + 1) % Number.MAX_VALUE;
   return count.toString();
 }
 
-type ActionType = typeof actionTypes;
+type ActionType = {
+  ADD_TOAST: 'ADD_TOAST';
+  UPDATE_TOAST: 'UPDATE_TOAST';
+  DISMISS_TOAST: 'DISMISS_TOAST';
+  REMOVE_TOAST: 'REMOVE_TOAST';
+};
 
 type Action =
   | {
@@ -187,4 +185,4 @@ function useToast() {
   };
 }
 
-export { useToast,  };
+export { useToast };

fresco.config.ts

@@ -1,7 +1,7 @@
-export const PROTOCOL_EXTENSION = '.netcanvas' as const;
+export const PROTOCOL_EXTENSION = '.netcanvas';
 export const APP_SUPPORTED_SCHEMA_VERSIONS = [7];
 // If unconfigured, the app will shut down after 2 hours (7200000 ms)
-export const UNCONFIGURED_TIMEOUT = 7200000 as const;
+export const UNCONFIGURED_TIMEOUT = 7200000;
 
 // Display options for dates: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat#using_options
 export const dateOptions: Intl.DateTimeFormatOptions = {

lib/cache.ts

@@ -1,22 +1,20 @@
 import { revalidateTag, unstable_cache } from 'next/cache';
 
-const CACHE_TAGS = [
-  'activityFeed',
-  'appSettings',
-  'getInterviews',
-  'summaryStatistics',
-  'getParticipants',
-  'getInterviewById',
-  'getProtocols',
-  'getInterviewsForExport',
-  'getProtocolsByHash',
-  'getExistingAssetIds',
-  'interviewCount',
-  'protocolCount',
-  'participantCount',
-] as const;
+type StaticTag =
+  | 'activityFeed'
+  | 'appSettings'
+  | 'getInterviews'
+  | 'summaryStatistics'
+  | 'getParticipants'
+  | 'getInterviewById'
+  | 'getProtocols'
+  | 'getInterviewsForExport'
+  | 'getProtocolsByHash'
+  | 'getExistingAssetIds'
+  | 'interviewCount'
+  | 'protocolCount'
+  | 'participantCount';
 
-type StaticTag = (typeof CACHE_TAGS)[number];
 type DynamicTag = `${StaticTag}-${string}`;
 
 type CacheTag = StaticTag | DynamicTag;

lib/data-table/types.ts

@@ -1,6 +1,5 @@
 import { type Prisma } from '@prisma/client';
 import * as z from 'zod';
-import { numberEnum } from '~/schemas/participant';
 
 export type Option = {
   label: string;
@@ -68,12 +67,10 @@ export const FilterParam = z.object({
 });
 export type FilterParam = z.infer<typeof FilterParam>;
 
-const SearchParamsSchema = z.object({
-  page: z.number(),
-  perPage: numberEnum(pageSizes),
-  sort: z.enum(sortOrder),
-  sortField: z.enum(sortableFields),
-  filterParams: z.array(FilterParam).nullable(),
-});
-
-export type SearchParams = z.infer<typeof SearchParamsSchema>;
+export type SearchParams = {
+  page: number;
+  perPage: number;
+  sort: (typeof sortOrder)[number];
+  sortField: (typeof sortableFields)[number];
+  filterParams: FilterParam[] | null;
+};