-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note on tangent type implementation #446
Conversation
Performance Ratio:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! very clear.
I would love to see an example of the Effects Etc
section, but probably for later.
Signed-off-by: Will Tebbutt <willtebbutt00@gmail.com>
Signed-off-by: Will Tebbutt <willtebbutt00@gmail.com>
Signed-off-by: Will Tebbutt <willtebbutt00@gmail.com>
Thanks @sunxd3 -- I've fixed a couple of typos that I've missed, and will now merge. |
Adds a note on the implementation of
tangent_type
and related functions. No version bump required because it's all in the docs.