Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broadcast::linked] Improve handling of partial acks in AckManager #487

Open
BrendanChou opened this issue Feb 12, 2025 · 0 comments
Open
Assignees

Comments

@BrendanChou
Copy link
Collaborator

Right now the AckManager does not replace the Evidence with a ThresholdSignature when enough PartialSignatures are gathered, it merely emits the value.

It may be cleaner to have the Evidence replaced immediately without having to call add_threshold() from signer/actor.rs.

This requires cleaning up some of the flow in signer/actor.rs and rewriting the code (and tests) in ack_manager.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant