Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] Emit Nullify and Nullification Proofs #444

Open
patrick-ogrady opened this issue Feb 3, 2025 · 1 comment · May be fixed by #462
Open

[consensus] Emit Nullify and Nullification Proofs #444

patrick-ogrady opened this issue Feb 3, 2025 · 1 comment · May be fixed by #462
Assignees
Labels
enhancement New feature or request

Comments

@patrick-ogrady
Copy link
Contributor

patrick-ogrady commented Feb 3, 2025

Some applications make use of nullify and nullification messages. We should expose them (like we do the other activity):

  • add NULLIFY:
    /// Notarize a payload at a given view.
    ///
    /// ## Clarifications
    /// * Vote for leader is considered a proposal and a vote.
    /// * It is ok to have both a vote for a proposal and the null
    /// container in the same view.
    /// * It is ok to notarize/finalize different proposals in the same view.
    pub const NOTARIZE: Activity = 0;
    /// Finalize a payload at a given view.
    pub const FINALIZE: Activity = 1;
    /// Notarize a payload that conflicts with a previous notarize.
    pub const CONFLICTING_NOTARIZE: Activity = 2;
    /// Finalize a payload that conflicts with a previous finalize.
    pub const CONFLICTING_FINALIZE: Activity = 3;
    /// Nullify and finalize in the same view.
    pub const NULLIFY_AND_FINALIZE: Activity = 4;
  • add skipped:
    /// Committer is the interface responsible for handling notifications of payload status.
    pub trait Committer: Clone + Send + 'static {
    /// Digest is an arbitrary hash digest.
    type Digest: Digest;
    /// Event that a payload has made some progress towards finalization but is not yet finalized.
    ///
    /// This is often used to provide an early ("best guess") confirmation to users.
    fn prepared(&mut self, proof: Proof, payload: Self::Digest) -> impl Future<Output = ()> + Send;
    /// Event indicating the container has been finalized.
    fn finalized(&mut self, proof: Proof, payload: Self::Digest) -> impl Future<Output = ()> + Send;
@patrick-ogrady patrick-ogrady added the enhancement New feature or request label Feb 3, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Tracker Feb 3, 2025
@patrick-ogrady patrick-ogrady self-assigned this Feb 3, 2025
@najeal
Copy link
Contributor

najeal commented Feb 5, 2025

@patrick-ogrady 👋

@najeal najeal linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants