-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript to the user guide #227
Comments
Thanks Bruno, happy to be assigned to this issue too |
This is cool, but also very advanced. Should definitely be in its own section, with lots of warnings. I have real concerns about the human portability of such an approach. Maybe the cwl-patterns repo is a better place to document this approach? https://github.com/common-workflow-library/cwl-patterns |
Yep, would definitely put this under an advanced topic but I think with good documentation concerns can be mitigated. I also agree that cwl-patterns is probably a good repo for this, since this is more of a conceptual best practise rather than a how-to. This CWL Patterns could also be show-cased more, I didn't know it existed until now (since it's under a different GitHub org). If we put this in the CWL patterns is there a way that we can link it in the user guide? |
There's an experimental cwltool feature that you might be interested in, it is exactly designed to formalize the concept of having a pre-process step to produce the code that will actually be executed, in this case compiling typescript to javascript: https://github.com/common-workflow-language/cwltool/blob/main/docs/processgen.rst |
I agree that it could be made more prominent. Currently the cwl patterns repo is listed without context or motivation as item 4 under "You also may be interested in:" on https://www.commonwl.org/user_guide/ (but "below the fold" of the first screen) |
Thanks for this, wasn't aware of this concept. To confirm, this process (typescript to javascript via tsc) would run at the start of every invocation? And is dependent on the workflow engine knowing how to correctly implement and use the ProcessGenerator extension? |
Follow-up for discussion from #222
#222 (comment)
We just need to define the public, how we will present, if we will list any pros & cons, if there are improvements necessary to be used by any user or if there are known issues, links to code repository, presentations, etc.
Also need to think where this could go. It could go into tutorials, how-tos, a dedicated section, maybe subsection of the expressions section, etc.
The text was updated successfully, but these errors were encountered: