system/manager: atomic power_watchdog write + self-check verification (fixes #36680) #36682
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36680
This PR addresses a race condition in
system/manager/manager.pythat caused unexpected device shutdowns.The Issue:
Previously,
manager.pyupdated the/var/tmp/power_watchdogfile by opening it withwmode, which truncates the file to 0 bytes before writing the new timestamp. If the external AGNOS power monitoring process read the file during this brief window, it would see an empty file (interpreted as 0), assume the watchdog had expired, and trigger an immediate shutdown.The Fix:
Implemented an atomic write pattern:
/var/tmp/power_watchdog.tmp).os.renameto atomically replace the target file.This guarantees that the reader process always sees a valid file content—either the old timestamp or the new one—but never an empty file.
Verification:
os.rename), a critical error is logged to help with future debugging.