tools: add retry mechanism for API requests #36617
Closed
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
requests has built-in retry mechanisms, i’d look into that over rolling your own (maybe 1 or 2 line code change) |
Contributor
Author
Good call, TIL. Thanks! |
Contributor
|
Should investigate the root cause first before hacks |
sunnyhaibin
force-pushed
the
api-retries
branch
from
cff3c3c to
8de91a3
Compare
Contributor
|
Will be fixed in the next release |
Contributor
|
This is good to have anyway, and we need to push that fix ASAP, not wait for a release. |
Collaborator
|
@sunnyhaibin would you like to reopen per adeeb's comment above? can't reopen here since the branch is deleted. looks like 10.2 isn't going out for 3X, and 10.3 will probably be awhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a retry mechanism for API requests to handle transient 5xx errors.