Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overflow and underflow variable setting #416

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

mafrahm
Copy link
Contributor

@mafrahm mafrahm commented Mar 28, 2024

This PR adds the possibility to move entries from the overflow (underflow) bin into the last (first) visible bin of the histogram during plotting. This can be enabled by adding the overflow (underflow) auxiliary to the variable inst or via variable_settings, e.g.

--variable-settings var_name,overflow

Closes #402

@mafrahm mafrahm added priority-low Low priority stuff plotting Plotting related things labels Mar 28, 2024
@mafrahm mafrahm self-assigned this Mar 28, 2024
@riga
Copy link
Member

riga commented May 31, 2024

@mafrahm Could you resolve the conflicts that appeared in the meantime? With that, everything looks good to me and we'd be ready to merge 👍

@riga riga self-requested a review May 31, 2024 13:00
Copy link
Member

@riga riga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@riga riga merged commit 05f0cde into master Jun 5, 2024
8 checks passed
@riga riga deleted the feature/use_flow_bins branch June 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plotting Plotting related things priority-low Low priority stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow Bins for Plotting
2 participants