Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip links broken in Firefox #1426

Open
matkoniecz opened this issue Oct 26, 2024 · 9 comments
Open

Tooltip links broken in Firefox #1426

matkoniecz opened this issue Oct 26, 2024 · 9 comments

Comments

@matkoniecz
Copy link
Contributor

screen01

@polly64
Copy link
Contributor

polly64 commented Oct 27, 2024

@mdsimpson42 can you correct this on Tuesday am confirm when completed here thanks

@matkoniecz
Copy link
Contributor Author

@mdsimpson42 Have you had time to investigate what went wrong here?

@mdsimpson42
Copy link
Contributor

The short answer is no. I missed the notification for this.

I can't replicate it. It appears to be working on the latest version of Colouring Britain both on production and in my local version.

image

If this is still happening, I will need more information. If its been resolved, then close the issue.

@matkoniecz
Copy link
Contributor Author

screen13

weird

I disabled adblock. I will try to disable all extensions and try with a Chrome. (I am using Firefox)

@mdsimpson42
Copy link
Contributor

mdsimpson42 commented Dec 6, 2024

Confirmed. All the links in the tooltips in that section don't seem to work in Firefox, even with AdBlock disabled. I'll look into it.

image

Edit: It seems to work in Chrome and Edge. Someone should check Safari...

@mdsimpson42
Copy link
Contributor

Just checked and it works on localhost, but not on colouringbritain.org...

image
image

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Dec 6, 2024

@mdsimpson42 Is it possible that it is something about a bit different version being deployed?

Can you test https://github.com/matkoniecz/colouring-core/tree/local_historians (https://github.com/matkoniecz/colouring-core repo, local_historians branch) locally?

@mdsimpson42
Copy link
Contributor

OK, so, I downloaded it and did some tests. I can confirm, I'm getting the bug in that version of the code.

  • I thought it might be that the link was too long, so I tried a shorter URL, but it still happens.
  • I thought it might be specific to the SliderDataEntry object, but I put a link in the tooltip of the 'How well do you know this building and its streetscape?' field, and that doesn't work either.
  • I thought it might be category-specific, but it appears on other fields as well, such as UPRNs in the location category.

image

I tried running Firefox in Troubleshoot mode, with all mods disabled, but that didn't fix it. I've also been Googling, but I can't seem to find a solution.


TLDR: None of the links in any of the tooltips are showing up correctly in Firefox, its not just limited to the paper links in the community section.

@mdsimpson42 mdsimpson42 changed the title Tooltip link broken in hominess Tooltip links broken in Firefox Dec 12, 2024
@matkoniecz
Copy link
Contributor Author

has it worked in past for Firefox? if for some old code version it worked also in Firefox then bisecting may reveal when problem was introduced...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants