-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Adding speaker on Win 11 #72
Comments
Is it the .ogg format it can't read? |
Same type of error that I received on windows 10 if I recall. |
If I change it to a wav file, it works but that wall of messages is still there. |
Have you verified that the ultimate audio file does in fact sound like the speaker that you tried to specify? |
Yes, it does work. Here is first Orson Wells and then Werner Herzog: 9739-10034.mp4 |
Cool, can you please post the script you used again? I still didn't get it working for some strange reason. |
|
I have no opinion on any particular library for sound files but I think:
Do we all agree that this would be a good list of requirements? |
My only thoughts are regarding numbers three and four above regarding "torchaudio". I originally was the one getting errors when using torchaudio on Windows that I think is the impetus for your message about possibly switching out torchaudio. To bring you up to speed...eventually I WAS able to resolve the torchaudio-related error we discussed. This required using This fully resolved the error regarding torchaudio. Thus, as long as it's clear that windows users (and possibly other platforms, I don't know?) might have to specifically install sounddevice, we shouldn't need to abandon torchaudio....that is, unless other users encounter different problems. Overall, I was NOT able to get a good tensor of a speaker's voice despite using very high quality audio, and I haven't re-tried since then. However, that's a separate issue and might involve my code...but as far as torchaudio and windows compatibility, hope this clarifies. |
Hey, thanks for explaining this. So it would look like we should check if we can add |
I would recommend adding it for Linux and Macos users as well. Apparently @signalprime encountered an error stating that torchaudio backend wasn't available, which was solved by pip installing soundfile. I believe his pull request might already do this. My comment above was half misinformed...I think I confused "soundfile" and "sounddevice" because the names are similar. Thus, to clarify my comment...I had to separately pip install As long as soundfile works on windows, mac, and linux, which it looks like it does, I'd recommend setting the default backend to soundfile instead of letting torchaudio automatically select it: https://pytorch.org/audio/2.0.0/backend.html My comments in @signalprime's pull request discuss this, but basically, soundfile is supposed to work on all three platforms whereas sox_io is only linux/mac. I researched the issue and this is a renmant of early pytorch versions. sox_io is located on sourceforge somewhere I believe...and then soundfile came around and was a hug improvement...But for some reason sox_io is still an option. Soundfile is updated constantly and recently, whereas I can't find any information on sox_io...even on sourceforge. Furthermore, torchaudio's github states confusingly that the "optional" dependencies are kaldi and soundfile...but not sox_io and soundfile like on their website's instructions... https://github.com/pytorch/audio/blob/main/requirements.txt Anyways, basically, to avoid my and @signalprime's errors, I'd recommend explicitly setting If you agree...here are the installation instructions: https://python-soundfile.readthedocs.io/en/latest/ Notice that they're somewhat different for Linux...so you may need to add an additional dependency for linux users named |
Finally found the website for sox...apparently it hasn't been updated since 2015 so I'm not sure why in the world Pytorch would use it. I say set the default to SoundDevice... :-) |
Hey, nice job finding all that info. I was not aware of the history behind the torchaudio backends! I agree with your conclusion - I’ll test a fresh Linux install and if you can confirm that torchaudio with soundfile works well on Windows then we can use this exclusively. I also implemented a workaround to support downloading the file from a URL, even without Sox. |
Trying to add speaker to the test file throws an error on Windows 11.
And this is the error:
The text was updated successfully, but these errors were encountered: