Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to onchainkit #260

Closed
kyhyco opened this issue Mar 19, 2024 · 4 comments
Closed

Add linting to onchainkit #260

kyhyco opened this issue Mar 19, 2024 · 4 comments

Comments

@kyhyco
Copy link
Contributor

kyhyco commented Mar 19, 2024

Describe the solution you'd like

We should add eslint, biome, etc. to lint our code. Any preference?

Describe alternatives you've considered.

No response
@Zizzamia
Copy link
Contributor

Be more specific, eslint is already present in the src folder.

@kyhyco
Copy link
Contributor Author

kyhyco commented Mar 19, 2024

Ah.. looks like eslint is only added to framegear. Will add it src and site

@roushou
Copy link
Contributor

roushou commented Jun 13, 2024

I think this issue can be closed since this PR #497 has been merged @kyhyco @Zizzamia

@kyhyco
Copy link
Contributor Author

kyhyco commented Jun 14, 2024

Yup you are right! Thank you so much @roushou!

@kyhyco kyhyco closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zizzamia @kyhyco @roushou