Skip to content
This repository has been archived by the owner on Sep 8, 2022. It is now read-only.

Errors should be publicly exported #12

Open
qdm12 opened this issue Dec 9, 2021 · 1 comment
Open

Errors should be publicly exported #12

qdm12 opened this issue Dec 9, 2021 · 1 comment

Comments

@qdm12
Copy link

qdm12 commented Dec 9, 2021

Right now errors are in the internal directory. That means a repository importing this one cannot import those error variables and thus cannot check the error with errors.Is(err, ErrXYZ).

One could move errors to their own errors package in pkg/errors or have them locally defined for each exported package.

@mikelodder7
Copy link
Contributor

Thanks for this. We can move them or we accept PRs to make the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants