Remove deprecated verifier and verification-pool-api packages (#3989)

### Description

Remove deprecated verifier and verification-pool-api packages. The pool appears to be causing test flakiness.
Tag created before this commit: https://github.com/celo-org/celo-monorepo/releases/tag/pre-ver-pool-and-app-removal

### Backwards compatibility

Yes

Author: jmrossy

.circleci/config.yml

@@ -514,25 +514,6 @@ jobs:
           name: Upload to CodeCov
           command: yarn codecov -F mobile
 
-  verification-pool-api:
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: ~/app
-
-      - run:
-          name: Check if the test should run
-          command: |
-            ./scripts/ci_check_if_test_should_run_v2.sh @celo/verification-pool-api
-
-      - run:
-          name: jest tests
-          command: |
-            mkdir -p test-results/jest
-            yarn --cwd packages/verification-pool-api test
-          environment:
-            JEST_JUNIT_OUTPUT: test-results/jest/junit.xml
-
   protocol-test:
     <<: *defaults
     resource_class: large
@@ -887,9 +868,6 @@ workflows:
           requires:
             - lint-checks
       - end-to-end-mobile-test-ios
-      - verification-pool-api:
-          requires:
-            - lint-checks
       - protocol-test:
           requires:
             - lint-checks

.dockerignore

@@ -15,6 +15,4 @@ packages/faucet
 packages/helm-charts
 packages/mobile
 packages/notification-service
-# packages/verification-pool-api
-packages/verifier
 packages/web

.github/CODEOWNERS

@@ -31,6 +31,4 @@
 /packages/transaction-metrics-exporter @nambrot
 /packages/typescript/ @cmcewen
 /packages/utils/ @jmrossy
-/packages/verification-pool-api/ @jmrossy @nambrot
-/packages/verifier/ @jmrossy @cmcewen
 /packages/web/ @cmcewen @aaronmgdr

.prettierignore

@@ -18,12 +18,9 @@ packages/protocol/scripts/**/*.js
 packages/protocol/migrations/**/*.js
 packages/protocol/test/**/*.js
 
-packages/verification-pool-api/contracts/*.ts
-
 packages/web/.next
 
 # prettier eats Latex underscore escapting and doesn't seem to have an option to disable
 packages/docs/celo-codebase/protocol/proof-of-stake/epoch-rewards.md
 
 packages/mobile/android/app/build
-packages/verifier/android/app/build

README-dev.md

@@ -37,7 +37,7 @@ Prefer appending a `-dev` suffix to the version number to ensure an internal dep
 
 > Note: Publishing breaking changes requires an increment to the minor version number for `0.` releases. Once `1.0.0` is pusblished breaking changes are generally prohibited outside the rare major version release. Read the [semver specification](https://semver.org/) for more information.
 
-> Note: Services deployed to App Engine must only depend on published NPM packages. These packages are `verification-pool-api`, `blockchain-api` and `notification-service`.
+> Note: Services deployed to App Engine must only depend on published NPM packages. These packages are `blockchain-api` and `notification-service`.
 
 ### Checkout the commit to be published and verify version numbers
 

README.md

@@ -125,8 +125,6 @@ The repository has the following packages (sub projects):
 - [transaction-metrics-exporter](packages/transaction-metrics-exporter) - monitoring tool that executes transactions on the network and exports testnet-level prometheus metrics
 - [typescript](packages/typescript) - no README available (improve?)
 - [utils](packages/utils) - no README available (improve?)
-- [verification-pool-api](packages/verification-pool-api) - service that handles a pool of Verifier App instances and requests them to direct SMS for attestation purposes (deprecated)
-- [verifier](packages/verifier) - Android verifier app to send SMS messages, enabling attestations of user phone numbers and their accounts on the Celo network
 - [web](packages/web) - Celo website ([live](https://celo.org/))
 
 Code owners for each package can be found in [.github/CODEOWNERS](.github/CODEOWNERS).

dependency-graph.json

@@ -24,8 +24,7 @@
       "@celo/contractkit",
       "@celo/dev-utils",
       "@celo/protocol",
-      "@celo/utils",
-      "@celo/verification-pool-api"
+      "@celo/utils"
     ]
   },
   "@celo/celocli": {
@@ -130,13 +129,6 @@
       "@celo/typescript"
     ]
   },
-  "@celo/verification-pool-api": {
-    "location": "packages/verification-pool-api",
-    "dependencies": [
-      "@celo/contractkit",
-      "@celo/utils"
-    ]
-  },
   "@celo/web": {
     "location": "packages/web",
     "dependencies": [

dockerfiles/celotool/Dockerfile

@@ -20,7 +20,6 @@ COPY packages/dev-utils/package.json packages/dev-utils/
 COPY packages/typescript/package.json packages/typescript/
 COPY packages/contractkit/package.json packages/contractkit/
 COPY packages/protocol/package.json packages/protocol/
-COPY packages/verification-pool-api/package.json packages/verification-pool-api/
 COPY packages/celotool/package.json packages/celotool/
 
 RUN yarn install --network-timeout 100000 --frozen-lockfile && yarn cache clean
@@ -30,7 +29,6 @@ COPY packages/dev-utils packages/dev-utils/
 COPY packages/typescript packages/typescript/
 COPY packages/contractkit packages/contractkit/
 COPY packages/protocol packages/protocol/
-COPY packages/verification-pool-api packages/verification-pool-api/
 COPY packages/celotool packages/celotool/
 
 RUN yarn build

packages/celotool/package.json

@@ -6,7 +6,6 @@
   "author": "Celo",
   "license": "Apache-2.0",
   "dependencies": {
-    "@celo/verification-pool-api": "^1.0.0",
     "@celo/utils": "0.1.15-dev",
     "@celo/contractkit": "0.4.6-dev",
     "@google-cloud/monitoring": "0.7.1",