Imp(archiver): leave at least two releases after archiving (#379)

* Imp(archiver): leave at least two releases after archiving

* test(archiver): add new test

* test(archiver): finish worker after handle

* try to fix tests

* chore(): typo fix

* test(): fix

* test(): fix

Author: e11sy

workers/archiver/src/index.ts

@@ -348,6 +348,7 @@ export default class ArchiverWorker extends Worker {
    * @param project - project to handle
    */
   private async removeOldReleases(project: ProjectDBScheme): Promise<number> {
+    const RELEASES_COUNT_TO_STAY = 2;
     const maxDaysInSeconds = +process.env.MAX_DAYS_NUMBER * HOURS_IN_DAY * MINUTES_IN_HOUR * SECONDS_IN_MINUTE;
     /**
      * Create timestamp for one month ago
@@ -365,6 +366,7 @@ export default class ArchiverWorker extends Worker {
         _id: { $lt: objectIdThreshold },
       })
       .sort({ _id: -1 })
+      .skip(RELEASES_COUNT_TO_STAY)
       .toArray();
 
     const filesToDelete = releasesToRemove.reduce<ReleaseFileData[]>(

workers/archiver/tests/index.test.ts

@@ -51,6 +51,10 @@ describe('Archiver worker', () => {
     await eventsCollection.insertMany(mockedEvents);
   });
 
+  beforeEach(async () => {
+    await db.collection('releases').deleteMany({});
+  })
+
   test('Should correctly remove old events', async () => {
     /**
      * Worker initialization
@@ -111,7 +115,9 @@ describe('Archiver worker', () => {
   test('Should remove old releases', async () => {
     await db.collection('releases').insertMany(mockedReleases);
 
-    const releaseToStay = {
+    const mockedReleasesLength = mockedReleases.length;
+
+    const releasesToStay = {
       _id: new ObjectId(),
       projectId: '5e4ff518628a6c714515f4da',
       release: 'releasetostay',
@@ -123,7 +129,7 @@ describe('Archiver worker', () => {
     /**
      * Insert one release with object id based on current time, it should not be removed
      */
-    await db.collection('releases').insert(releaseToStay);
+    await db.collection('releases').insert(releasesToStay)
 
     const worker = new ArchiverWorker();
 
@@ -136,11 +142,41 @@ describe('Archiver worker', () => {
       .find({})
       .toArray();
 
-    expect(newReleasesCollection).toEqual([ releaseToStay ]);
-    expect(gridFsDeleteMock).toHaveBeenCalledTimes(mockedReleases.length);
+    expect(newReleasesCollection).toEqual([
+      mockedReleases[mockedReleasesLength - 2],
+      mockedReleases[mockedReleasesLength - 1],
+      releasesToStay,
+    ]);
+
+    expect(gridFsDeleteMock).toHaveBeenCalledTimes(mockedReleases.length - 2);
     await worker.finish();
   });
 
+  test('Should leave two releases if all of the releases are more than month old', async () => {
+    /**
+     * Clear collection after previous test
+     */
+    await db.collection('releases').insertMany(mockedReleases);
+
+    const mockedReleasesLength = mockedReleases.length;
+
+    const worker = new ArchiverWorker();
+
+    await worker.start();
+
+    await worker['removeOldReleases'](mockedProject);
+
+    const newReleasesCollection = await db.collection('releases')
+      .find({})
+      .toArray();
+
+    expect(newReleasesCollection).toEqual([
+      mockedReleases[mockedReleasesLength - 2],
+      mockedReleases[mockedReleasesLength - 1],
+    ])
+    await worker.finish();
+  })
+
   afterAll(async () => {
     await db.dropCollection('releases');
     await db.dropCollection('projects');