Switch from node-ytsr to Distube's fork #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
1 task
|
Any news on this? node-ytsr is still broken, it would be nice to have this merged. |
|
I somehow didn't see this in April, sorry. I ended up merging #1042 instead. |
|
My bad, got dependencies mixed up, this is still useful and appreciated :) |
|
🚀 Released in Release v2.9.0. |
3 tasks
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1000
Tried dropping in the ytsr fork as a direct replacement to the deprecated node-ytsr. Seems to work perfectly fine when I tested locally.
The "biggest" change here would be the modification of the minimum Node version requirement to 18 as the fork dropped version 16. I assume it would be fine as the Dockerfile use version 18 anyways.