Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Labels #10

Open
simplesteph opened this issue Mar 7, 2017 · 1 comment
Open

Support for Labels #10

simplesteph opened this issue Mar 7, 2017 · 1 comment

Comments

@simplesteph
Copy link
Contributor

It seems that docker-gen as of 0.4.0 supports placing some variables in labels instead of environment variables, which is a bit cleaner.

nginx-proxy/nginx-proxy#172 (comment)

Thoughts on implementing this?
I could try doing a PR at some point

@codesuki
Copy link
Owner

codesuki commented Mar 8, 2017

If you want to do that you have to read about docker labels here:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html

We can access those parameters.

For me it would be low priority because it works fine with environment variables for now. I would prefer to add path (instead of domain) mapping and authentication first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants