-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve version compatibility #224
Comments
As an extra check, we could pass in the Coder version to the provisioner, and then check the version against the oldest version of Coder supported by the provisioner. WDYT? |
I think passing the version is a good idea, but I think we should add rules to convert old parameters into new ones instead of "breaking" at certain version boundaries. We want to minimize upgrade anxiety caused by breakage. |
In coder/coder#13122 a user sees empty values when referencing
${data.coder_workspace.me.template_id}
in their template. This happens because their coder server version is behind the provider, and this kind of issue will continue to appear as we implement more provider functionality (#220, #219).There are two things we should do to fix this:
In our docs under each attribute and resource, declare the Coder version requirements
Replace code like:
terraform-provider-coder/provider/workspace.go
Lines 83 to 90 in 3cc9802
with
LookupEnv
and fail the build when a value is missing instead of using blanks.The text was updated successfully, but these errors were encountered: