Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): Sync winget-pkgs fork before publishing #11842

Closed
mdanish-kh opened this issue Jan 26, 2024 · 1 comment · Fixed by #11865
Closed

ci(release): Sync winget-pkgs fork before publishing #11842

mdanish-kh opened this issue Jan 26, 2024 · 1 comment · Fixed by #11865
Assignees
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Jan 26, 2024

Description

Take a look at - https://github.com/coder/coder/actions/runs/7611646446/job/20727993997 (and other release runs)

Publishing to winget failed because:

Submitting pull request for manifest...

Unable to create a reference to the forked repository. This can be caused when the forked repository is behind by too many commits. Sync your fork and try again.
Error: Process completed with exit code 1.

Steps to fix

This will reproduce for subsequent releases/runs until the fork used for submitting PR is kept in sync with upstream.

i.e., https://github.com/cdrci/winget-pkgs in this case

WingetCreate does attempt to sync the fork before making a PR, but that can fail if the fork is behind too many commits.

Suggest to make it as part of CI to sync the fork (through gh CLI?) before winget publish step to avoid this in the future

Upstream issue

Related to:

@matifali
Copy link
Member

Thanks a lot @mdanish-kh. I will fix this before the next release.

@matifali matifali added bug s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. and removed chore labels Jan 26, 2024
@matifali matifali self-assigned this Jan 26, 2024
matifali added a commit that referenced this issue Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants