-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Candidate page UI issues/improvements #137
Comments
@alessandro-pianetta: Did you make note of the UX issues on the candidate page we talked about with Diane? I tried to just jot down everything I saw looking at the page just now, but I think I'm missing some stuff. |
Oh great, I should have checked out your PRs first! Yeah some of these are new as I'm working on hooking up the candidate data, I just wanted to make a note of them someplace as I thought of them. |
For F I think we decided to render them as a column due to wrapping issues at smaller screen sizes between 1440 and the break point. |
A - SideNav container padding causes H3s to be misaligned (the candidate's name should be aligned with the section headers beneath)
B - The 'See all contributions' text doesn't align properly with the arrow, doesn't match arrow color, and also doesn't do anything when you click on it (where should it go?) - Design is fixed, but currently no page to link it to
C - We're still missing profile photos. Should we ask for a default profile photo to use in case we can't get them all?
D - Voter's Edge link doesn't go anywhere, that needs to be added to candidate JSON file
E - Candidate description/bio (what should go there?) needs to be added to candidate JSON file
F - Fix positioning/wrap of bio links (row or col?)
G - Total contributions currently only includes RCPT. Do we want to include LOAN? If so, we need to update the aggregations on candidate and election for consistency (API changes needed).
H - We have a lot of expenditure data, so I'm currently only showing top 4 categories. Should we make this expandable?
I - Need more padding between sections
J - Text is wrapping too much in the chart labels, can we adjust the width/margin for the label to make it.. not do that?
K - Breakdown by region is currently missing the "In San José" category - need to get that from the API (when we do, we need to decide - should "In California" also include SJ, or no?)
L - Both of the funding breakdowns are currently only including RCPT. Should they also include LOAN?The text was updated successfully, but these errors were encountered: