-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: CODE PDX logo contrast #80
Comments
Having it just use a different, better contrasting image depending on specific conditions seems like the simplest solution. I don't know enough about branding or UX to say whether it's important that logos be completely uniform (i.e. the exact same colors and everything no matter the conditions). But I don't think just changing the hue really hurts the "brand" that much. Especially if that's what we're going to do with dark mode anyway. Not sure what the plan is with that. |
This will be fixed as part of the issue I have for the nav and footer. It was originally white and worked fine but we were asked to change the color. |
ahhh didn't realize. Want me to make issue for footer and delete this one? |
It's not perfect, but I have this (as I was working on it before your comment.) I also didn't see any footer issue, so not sure if there's anything else to fix there (besides the links.) Let me know your thoughts. Could delete this issue/approach entirely. Could review this and push this change, then just edit the Navbar issue to not include this piece of it. etc. Screen.Recording.2023-12-28.at.8.17.19.AM.mov |
I didn't notice but I guess it wasn't actually added as an issue. It just vaguely says contrast but thats what it was referring to. The logo and CODE PDX text need to be updated for both. I'm ok with these changes and can work from there. |
This issue was resolved, not sure when but logos were changed to white to help with contrast. Will re open a new issue if other changes are needed. |
Describe the Current Behavior/Feature:
CODE PDX logo in Navbar and Footer don't have enough contrast at some viewports either due to blobs rendering or not, OR light mode vs dark mode.
Proposed Implementation:
Maybe just functionally determining the src file of the image based on conditions?
The text was updated successfully, but these errors were encountered: