Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for instanceof Error #937

Open
knod opened this issue Oct 31, 2018 · 0 comments
Open

Check for instanceof Error #937

knod opened this issue Oct 31, 2018 · 0 comments
Labels
beginner friendly For those new to coding. infrastructure
Projects
3:4 Maintainability

Comments

@knod
Copy link
Collaborator

knod commented Oct 31, 2018

In 'src/utils/valueFixers.js' isNumberlike() change from

if (typeof trueOrError === `object`) { //...

to

if (typeof trueOrError instanceof Error) { //...
@knod knod added infrastructure beginner friendly For those new to coding. labels Oct 31, 2018
@knod knod added this to To do in 3:4 Maintainability via automation Oct 31, 2018
migueldcepeda added a commit that referenced this issue Jan 29, 2019
@migueldcepeda
Fix error handling, Issue #937
231f137
knod added a commit that referenced this issue Jan 31, 2019
@knod
Merge pull request #1055 from codeforboston/fix__valueFixers-error-check
4be9e1d 
Fix error handling, Issue #937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly For those new to coding. infrastructure
Projects
3:4 Maintainability
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knod