Skip to content
This repository has been archived by the owner on May 8, 2021. It is now read-only.

Unclear/Confusing Tests #2

Open
sjgllghr opened this issue Sep 29, 2018 · 0 comments
Open

Unclear/Confusing Tests #2

sjgllghr opened this issue Sep 29, 2018 · 0 comments

Comments

@sjgllghr
Copy link

Some tests run with ./jake.sh test have confusing error messages that make it difficult to tell what the correct formatting is. Such as:

Font weight should be 700: expected '700' to equal 'bold'
(Message - should be 700: actual is 700, expected to be bold?)

It looks like there are a whole sections of tests that have either the wrong expected value or
the wrong error message.

Examples:

it('has correct font-weight', function () {
assert.equal(h1.getRawStyle('font-weight'), 'bold', 'Font weight should be 700');
assert.equal(h2.getRawStyle('font-weight'), 'bold', 'Font weight should be 700');
assert.equal(h3.getRawStyle('font-weight'), 'bold', 'Font weight should be 700');
assert.equal(h4.getRawStyle('font-weight'), 'bold', 'Font weight should be 700');
assert.equal(h5.getRawStyle('font-weight'), 'bold', 'Font weight should be 700');
assert.equal(h6.getRawStyle('font-weight'), 'normal', 'Font weight should be 400');

assert.equal(lead.getRawStyle('font-family'), 'Merriweather, georgia', 'Lead font should be Source Sans Pro');

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant