Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerender User & Concept pages with Vercel Prerender Functions #2645

Closed
wants to merge 11 commits into from
Closed

Prerender User & Concept pages with Vercel Prerender Functions #2645

wants to merge 11 commits into from

Conversation

VasylMarchuk
Copy link
Collaborator

@VasylMarchuk VasylMarchuk commented Feb 11, 2025 •
edited
Loading

Closes #2607

Brief

This adds server-side rendering for /users/:username and /concepts/:concept routes, based on Vercel's Prerender Functions.

Details

TBD

Checklist

  • I've thoroughly self-reviewed my changes
  • I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
  • I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

@VasylMarchuk VasylMarchuk added the enhancement New feature or request label Feb 11, 2025
@VasylMarchuk VasylMarchuk self-assigned this Feb 11, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.44kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 36.18MB 1.44kB (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js 1.44kB 2.44MB 0.06%
assets/chunk.*.js 6 bytes 22.86kB 0.03%

Files in assets/chunk.*.js:

  • ./routes/user.ts → Total Size: 4.64kB

  • ./config/environment.js → Total Size: 702 bytes

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

Test Results

  1 files  ±0    1 suites  ±0   6m 26s ⏱️ -1s
617 tests ±0  574 ✅  - 1  41 💤 ±0  0 ❌ ±0  2 🔥 +1 
632 runs  ±0  587 ✅  - 2  41 💤 ±0  2 ❌ +1  2 🔥 +1 

For more details on these errors, see this check.

Results for commit 65eb784. ± Comparison against base commit 4303bee.

This pull request removes 617 and adds 617 tests. Note that renamed tests count towards both. 
Chrome 132.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection
Chrome 132.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page
Chrome 132.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page
Chrome 132.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid
Chrome 132.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid
…

Chrome 133.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection
Chrome 133.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page
Chrome 133.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page
Chrome 133.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid
Chrome 133.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid
…
This pull request removes 41 skipped tests and adds 41 skipped tests. Note that renamed tests count towards both. 
Chrome 132.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > crosshairCursor: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > drawSelection: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > dropCursor: it does something useful with the editor
Chrome 132.0 ‑ Integration | Component | code-mirror > Options > editable: it does something useful with the editor
…

Chrome 133.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > crosshairCursor: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > drawSelection: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > dropCursor: it does something useful with the editor
Chrome 133.0 ‑ Integration | Component | code-mirror > Options > editable: it does something useful with the editor
…

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
577 2 575 41
View the top 2 failed test(s) by shortest run time 
Chrome 133.0 Acceptance | view-code-walkthrough: it renders code walkthrough
Stack Traces | 1.18s run time 
Promise rejected during "it renders code walkthrough": Loading chunk vendors-assets__route__code-walkthrough_js failed.
(error: http://localhost:7357/assets/chunk.c64b9dd3ab7602e14fa1.js)
Chrome 133.0 Integration | Component | code-mirror &gt; Options &gt; filename: it doesn't break the editor when passed
Stack Traces | 5.04s run time 
Test took longer than 5000ms; test timed out.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from 42fda27 to 29c0ee2 Compare February 12, 2025 08:29
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch 2 times, most recently from 5afbf76 to 3357677 Compare February 12, 2025 08:37
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from 1a440e0 to edac825 Compare February 12, 2025 09:33
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from bfa62fa to 55028a7 Compare February 12, 2025 09:53
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from 55028a7 to c0a5134 Compare February 12, 2025 10:09
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from 0c1d719 to ef34a61 Compare February 12, 2025 13:31
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from ef34a61 to 39e0ef9 Compare February 12, 2025 13:53
@VasylMarchuk VasylMarchuk force-pushed the statically-rendered-pages branch from 39e0ef9 to a1cde9f Compare February 12, 2025 14:11
@VasylMarchuk
Copy link
Collaborator Author

Closing in favour of #2653. Prerendering of Concept pages will be done in a separate PR.

@VasylMarchuk VasylMarchuk deleted the statically-rendered-pages branch February 12, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VasylMarchuk VasylMarchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statically rendered user pages + concept pages
1 participant
@VasylMarchuk