Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card items overflow out of cards #1768

Open
mtlaso opened this issue May 24, 2024 · 10 comments
Open

Card items overflow out of cards #1768

mtlaso opened this issue May 24, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@mtlaso
Copy link

mtlaso commented May 24, 2024

Details

Steps

  1. Visit someone's profile (https://app.codecrafters.io/users/rohitpaulk)
  2. Look into the challenges section
  3. Some icons are overflowing out of their card (when a challenge has been solved with multiple languages)

(firefox)
firerfox

(chromium)
chrome

Proposed solution

Make sure the icons don't overflow

@mtlaso mtlaso added the sweep Assigns Sweep to an issue or pull request. label May 24, 2024
@rohitpaulk rohitpaulk changed the title Sweep: Card items overflow out of cards Card items overflow out of cards Jul 29, 2024
@rohitpaulk
Copy link
Member

Spec for solution: let's pick upto 3 languages. Prioritize based on this ordered list:

  • Completed languages, sorted by last activity
  • Incomplete languages, sorted by last activity

@rohitpaulk rohitpaulk added bug Something isn't working and removed sweep Assigns Sweep to an issue or pull request. labels Jul 29, 2024
@yuvrajkarna2717
Copy link

"Hi @rohitpaulk, is this issue still relevant to work on? If yes, could you provide more details or context to help improve it?

@rohitpaulk
Copy link
Member

@yuvrajkarna2717 yep! We should limit to 3 icons, you'll find the spec above here: #1768 (comment)

@Wassaf001
Copy link

Hey, what should I add in .env, backend url?

This should match the URL defined in core.

BACKEND_URL="https://-backend.ccdev.dev"

@ryan-gang
Copy link
Contributor

You can use our staging server to develop against.
BACKEND_URL="https://backend-staging.codecrafters.io"

@Wassaf001
Copy link

ok thanks

@rohitpaulk
Copy link
Member

Added this to our default .env.example here: #2639

@Wassaf001
Copy link

I am wondering, how can I check my code is working or not, as I cannot reproduce the bug.

Any help please.

@rohitpaulk
Copy link
Member

@Wassaf001 you can try editing this file to mimic the scenario: https://github.com/codecrafters-io/frontend/blob/main/tests/acceptance/view-user-profile-test.js. You can add pauseTest() as described here to see the UI in the middle of a test.

@Wassaf001
Copy link

ok thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants